Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manuals.yml (YML) #1697

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jul 18, 2024

About the PR

Copy paste is bad

Why / Balance

Clean yml

How to test

N/A

Media

N/A

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jul 18, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned through changes, looks good, will quickly test.

@dvir001
Copy link
Contributor Author

dvir001 commented Jul 18, 2024

Merge conflicts go brrrrr

Fixed.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd request that the names of the ships be capitalized in the name if you care.

@dvir001 dvir001 requested a review from whatston3 July 18, 2024 22:19
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@whatston3 whatston3 merged commit 2984fd5 into new-frontiers-14:master Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants